Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor] add az monitor data-collection commands #2756

Merged

Conversation

kairu-ms
Copy link
Contributor

@kairu-ms kairu-ms commented Dec 7, 2020

Close Azure/azure-cli#15970
Close Azure/azure-cli#15543


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@kairu-ms kairu-ms changed the title Feature 15543 azure monitor control service [Monitor] add az monitor data-collection commands Dec 7, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 7, 2020

Monitor

@yonzhan yonzhan added this to the S179 milestone Dec 7, 2020
@jsntcy jsntcy requested a review from msyyc December 7, 2020 02:04
@kairu-ms kairu-ms force-pushed the feature-15543-azure-monitor-control-service branch from 84df3bb to 3c933a9 Compare December 7, 2020 03:06
Copy link
Contributor

@haroldrandom haroldrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix comments above

@yonzhan yonzhan modified the milestones: S179, S180 Dec 7, 2020
@kairu-ms kairu-ms force-pushed the feature-15543-azure-monitor-control-service branch from eec1950 to 87a6e87 Compare December 8, 2020 05:19
@kairu-ms kairu-ms requested a review from haroldrandom December 8, 2020 05:42
@kairu-ms kairu-ms merged commit 21be52f into Azure:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants